Output should indicate if a pull results in an update #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickycode
approved these changes
Jul 6, 2023
fredcooke
requested changes
Jul 6, 2023
| projectContextStatus "${projectName}" "Pulled " | ||
| postPullHash=$(git rev-parse HEAD 2>/dev/null) | ||
| if test "${prePullHash}" = "${postPullHash}"; then | ||
| projectContextStatus "${projectName}" "Good " |
There was a problem hiding this comment.
I'd much rather this said Current or Matches or UpToDate or something meaningful that fits rather than simply "Good". What if it's bad that there's no new change when you fetch?
There was a problem hiding this comment.
or Unchanged or No change or ? I feel like any of the 5 suggestions I've given are better than Good but also that maybe there's a better word/phrase than any of them.
There was a problem hiding this comment.
Changing Good to something else is fine with me. Of those 5 suggestions which one do you like best?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be nice if the output to
branchout pullindicated whether a repo was updated or already up-to-date.Currently the same output is shown for both cases, i.e.:
This PR changes the output to indicate when a repo is up-to-date:
Updated:
Up to date: