-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#191] Fix: 스타일 및 버그 수정 #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HoberMin
approved these changes
Apr 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
희라님 군데군데 작업하느라 고생많이 하셨습니다 !
변경사항들에 대해서 간단한 리뷰들만 작성해서 반영되면 resolve직접 해주셔도 좋을 것 같아요
그리고 추가적으로 기억이 잘 안나서 그러는데 맥os에서 select어떻게 처리하기로 했었죠..? 맥에서는 기본 select로 동작해서 스타일이 안입혀지네요
Deploying boardsignal with
|
Latest commit: |
f292542
|
Status: | ✅ Deploy successful! |
Preview URL: | https://e2301153.team-civilwar-boardsignal-fe.pages.dev |
Branch Preview URL: | https://191-fix-page-style-and-bug-f.team-civilwar-boardsignal-fe.pages.dev |
This was referenced May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💬 Issue Number
🤷♂️ Description
Modal
,Select
z-index
속성 수정object-fit
속성 수정white-space
속성 수정Suspense
추가text-align
속성 수정📷 Screenshots
모달
보드게임 상세 이미지
모임 설명
📋 Check List