Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FILTER: Add RemoveFlaggedEdges filter. Update other RemoveFlaggedXXX filters #986

Conversation

imikejackson
Copy link
Contributor

@imikejackson imikejackson commented Jun 3, 2024

TODO:

  • Update RemoveFlaggedVertices to copy data
  • Update RemoveFlaggedVertices to accept mask of uint8 or bool
  • Update Test cases for RemoveFlaggedTriangles/Vertices/Edges
  • Polish documentation
  • Update data archive with new test cases
  • Add example pipeline for remove flagged triangle and add cmake testing for it (using relative paths)
  • Reorder parameters for all 3 filters for visibility
  • Extract anonymous namespace in header into 'detail'

@imikejackson imikejackson marked this pull request as draft June 3, 2024 13:20
@imikejackson imikejackson requested a review from nyoungbq June 3, 2024 13:20
@imikejackson imikejackson force-pushed the topic/remove_flagged_edges branch 3 times, most recently from 4741a70 to 1de7449 Compare June 5, 2024 12:54
@imikejackson imikejackson force-pushed the topic/remove_flagged_edges branch from 1de7449 to b00a5fa Compare June 24, 2024 13:35
@nyoungbq nyoungbq force-pushed the topic/remove_flagged_edges branch from b00a5fa to 1a7fe56 Compare June 28, 2024 20:56
@nyoungbq nyoungbq marked this pull request as ready for review June 28, 2024 20:57
imikejackson and others added 15 commits June 28, 2024 16:57
Signed-off-by: Michael Jackson <[email protected]>
created functions to aggregate most of the data transfer codes into a few spots.

Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
- RemoveFlaggedVertices copy data (default)
- Updated RemoveFlaggedVertices to accept mask of uint8 or bool
- Reordered parameters for all 3 filters for visibility
- Extracted anonymous namespace in header into 'detail'
@nyoungbq nyoungbq force-pushed the topic/remove_flagged_edges branch from 1a7fe56 to 022cd44 Compare June 28, 2024 20:58
@imikejackson imikejackson requested a review from nyoungbq July 1, 2024 15:20
@imikejackson imikejackson merged commit d719016 into BlueQuartzSoftware:develop Jul 1, 2024
8 checks passed
@imikejackson imikejackson deleted the topic/remove_flagged_edges branch July 1, 2024 15:22
imikejackson added a commit to imikejackson/simplnx that referenced this pull request Oct 20, 2024
…filters (BlueQuartzSoftware#986)

- Implemented RemoveFlaggedEdges filter with option to copy cell and vertex data
- Added copying options to RemoveFlaggedTriangles and RemoveFlaggedVertices data
- Added Unit test updates
- Updated documentation for all filters
- Added example pipelines for new/updated filters


Signed-off-by: Michael Jackson <[email protected]>
Co-authored-by: nyoungbq <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants