Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] FILTER: RemoveFlaggedTriangles. #678

Conversation

imikejackson
Copy link
Contributor

Code is stubbed out only.

Naming Conventions

Naming of variables should descriptive where needed. Loop Control Variables can use i if warranted. Most of these conventions are enforced through the clang-tidy and clang-format configuration files. See the file complex/docs/Code_Style_Guide.md for a more in depth explanation.

Filter Checklist

The help file complex/docs/Porting_Filters.md has documentation to help you port or write new filters. At the top is a nice checklist of items that should be noted when porting a filter.

Unit Testing

The idea of unit testing is to test the filter for proper execution and error handling. How many variations on a unit test each filter needs is entirely dependent on what the filter is doing. Generally, the variations can fall into a few categories:

  • 1 Unit test to test output from the filter against known exemplar set of data
  • 1 Unit test to test invalid input code paths that are specific to a filter. Don't test that a DataPath does not exist since that test is already performed as part of the SelectDataArrayAction.

Code Cleanup

  • No commented out code (rare exceptions to this is allowed..)
  • No API changes were made (or the changes have been approved)
  • No major design changes were made (or the changes have been approved)
  • Added test (or behavior not changed)
  • Updated API documentation (or API not changed)
  • Added license to new files (if any)
  • Added example pipelines that use the filter
  • Classes and methods are properly documented

@imikejackson imikejackson requested a review from JDuffeyBQ August 28, 2023 02:15
@imikejackson imikejackson added enhancement New feature or request Filter Adds a new filter labels Aug 28, 2023
@imikejackson imikejackson marked this pull request as draft August 28, 2023 02:15
@imikejackson imikejackson changed the title FILTER: RemoveFlaggedTriangles. [WIP] FILTER: RemoveFlaggedTriangles. Aug 28, 2023
@imikejackson imikejackson force-pushed the filter/remove_flagged_triangles branch from 44aac8f to 7e2833b Compare August 28, 2023 02:16
@nyoungbq nyoungbq force-pushed the filter/remove_flagged_triangles branch 2 times, most recently from 67d80d9 to f16994f Compare September 5, 2023 12:18
@imikejackson imikejackson requested review from mmarineBlueQuartz and removed request for JDuffeyBQ September 8, 2023 15:05
@nyoungbq nyoungbq force-pushed the filter/remove_flagged_triangles branch 3 times, most recently from bd91eba to 666d6b6 Compare September 13, 2023 20:38
@nyoungbq nyoungbq force-pushed the filter/remove_flagged_triangles branch from 666d6b6 to b17c57d Compare October 3, 2023 14:21
@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @imikejackson for code

@allcontributors
Copy link
Contributor

@nyoungbq

We had trouble processing your request. Please try again later.

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @imikejackson for code

@allcontributors
Copy link
Contributor

@nyoungbq

We had trouble processing your request. Please try again later.

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @nyoungbq for code

@allcontributors
Copy link
Contributor

@nyoungbq

We had trouble processing your request. Please try again later.

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @nyoungbq for code

@allcontributors
Copy link
Contributor

@nyoungbq

This project's configuration file has malformed JSON: .all-contributorsrc. Error:: Unexpected string in JSON at position 269

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

https://github.com/all-contributors please add @nyoungbq for code

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @nyoungbq for code

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @nyoungbq! 🎉

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @imikejackson for code
@all-contributors please add @JDuffeyBQ for code
@all-contributors please add @jmarquisbq for code
@all-contributors please add @joeykleingers for code
@all-contributors please add @mmarineBlueQuartz for code
@all-contributors please add @VKUDRI for code
@all-contributors please add @bpenniebq for code
@all-contributors please add @john-stone-ics for code
@all-contributors please add @nyoungbq for code

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @JDuffeyBQ for code

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @nyoungbq! 🎉

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @bpenniebq for code

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @bpenniebq! 🎉

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @john-stone-ics for code

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @john-stone-ics! 🎉

@nyoungbq
Copy link
Contributor

nyoungbq commented Oct 5, 2023

@all-contributors please add @VKUDRI for code

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @VKUDRI! 🎉

@nyoungbq
Copy link
Contributor

@all-contributors please add @yliu2019 as a contributor for research and data

@allcontributors
Copy link
Contributor

@nyoungbq

I've put up a pull request to add @yliu2019! 🎉

@nyoungbq nyoungbq force-pushed the filter/remove_flagged_triangles branch from b17c57d to 9bb5a55 Compare October 17, 2023 18:54
@imikejackson
Copy link
Contributor Author

Merged with #842

@imikejackson imikejackson deleted the filter/remove_flagged_triangles branch February 2, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Filter Adds a new filter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants