ENH: Fix multiple compiler warnings and other small issues #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JDuffeyBQ
approved these changes
Oct 17, 2024
imikejackson
changed the title
imikejackson
force-pushed
the
topic/misc_fixes
branch
from
ceeb19e to
35b5ce3
Compare
imikejackson
force-pushed
the
topic/misc_fixes
branch
from
35b5ce3 to
231e190
Compare
mmarineBlueQuartz
approved these changes
Oct 22, 2024
JDuffeyBQ
requested changes
Oct 22, 2024
imikejackson
force-pushed
the
topic/misc_fixes
branch
3 times, most recently
from
ecc1747 to
6a3444c
Compare
JDuffeyBQ
reviewed
Oct 28, 2024
Signed-off-by: Michael Jackson <[email protected]>
Signed-off-by: Michael Jackson <[email protected]> (cherry picked from commit 9d2eb6b)
imikejackson
force-pushed
the
topic/misc_fixes
branch
from
6a3444c to
2322438
Compare
imikejackson
force-pushed
the
topic/misc_fixes
branch
from
2322438 to
2a174de
Compare
Some data arrays had their component dimensions attribute written incorrectly. Signed-off-by: Michael Jackson <[email protected]>
imikejackson
force-pushed
the
topic/misc_fixes
branch
from
2a174de to
288bc58
Compare
JDuffeyBQ
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.