-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Update required standard to C++20 #1004
Conversation
2b13c86
to
fd16894
Compare
e8a1f9c
to
f01390a
Compare
Some notes:
|
Yeah I was waiting until this gets merged to do any improvements to keep this PR minimal. For The issue with |
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Ensures the __cplusplus macro has the correct value * The default behavior has it set to 199711L for legacy reasons Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* cbegin()/cend() for std::span won't be added until C++23 Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Functors passed to tbb::parallel_for must satisfy the parallel_for_body concept which requires that they are copy constructible Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Causes issues on macOS and already covered by uint64 array Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Michael Jackson <[email protected]>
* Code outside of sections runs again for each section which was not necessary for this test case Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* May be temporary depending on feedback on the issue Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
Signed-off-by: Jared Duffey <[email protected]>
* Updated to Eigen 3.4.0 * Updated to expected-lite 0.8.0 * Updated to nod 0.5.4 * Removed gcc9 CI * Added /Zc:__cplusplus compile flag for msvc * Fixed fmtlib formatting * Fixed tbb::parallel_for functors * Functors passed to tbb::parallel_for must satisfy the parallel_for_body concept which requires that they are copy constructible * Fixed various compile errors on C++20 * Fixed FeatureFaceCurvatureTest where the principal directions are unique up to a sign * Fixed ComputeFeatureReferenceCAxisMisorientationsTest and ComputeFeatureNeighborCAxisMisalignmentsTest by using double precision to get the values to agree on all platforms regardless of vectorization Signed-off-by: Jared Duffey <[email protected]> Signed-off-by: Michael Jackson <[email protected]> Co-authored-by: Michael Jackson <[email protected]>
No description provided.