Minor review fixes

BlueQuartzSoftware · Aug 8, 2024 · a503f66 · a503f66
1 parent 91418fb
commit a503f66
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 7 deletions.
diff --git a/src/simplnx/Common/Ray.hpp b/src/simplnx/Common/Ray.hpp
@@ -8,7 +8,6 @@
 
 namespace nx::core
 {
-
 /**
  * @class Ray
  * @brief The Ray class describes a ray or line segment in 3D space. Using

diff --git a/src/simplnx/Utilities/Math/GeometryMath.hpp b/src/simplnx/Utilities/Math/GeometryMath.hpp
@@ -39,10 +39,7 @@ struct GeometryStoreCache
   usize NumVertsPerFace;
 };
 
-template <typename T>
-concept FloatType = std::is_floating_point_v<T>;
-
-template <FloatType FloatT>
+template <std::floating_point FloatT>
 std::array<Point3D<FloatT>, 3> GetFaceCoordinates(const GeometryStoreCache& cache, usize faceId, std::vector<usize>& verts)
 {
   std::array<Point3D<FloatT>, 3> points;
@@ -759,8 +756,7 @@ char IsPointInPolyhedron(const nx::core::TriangleGeom& triangleGeomRef, const st
   } /* End while loop */
 
   /* q strictly interior to polyhedron if an odd number of crossings. */
-  // Bitwise & for speed
-  if(crossings & 1)
+  if(crossings % 2 != 0)
   {
     return 'i';
   }
-Original file line number
+Diff line change
@@ Expand Up / @@ -8,7 +8,6 @@ @@
     namespace nx::core
     {
     /**
      * @class Ray
      * @brief The Ray class describes a ray or line segment in 3D space. Using
@@ Expand Down @@