Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tool unit tests #44

Merged
merged 44 commits into from
Dec 19, 2024
Merged

Tool unit tests #44

merged 44 commits into from
Dec 19, 2024

Conversation

cszsol
Copy link
Collaborator

@cszsol cszsol commented Nov 5, 2024

No description provided.

@cszsol
Copy link
Collaborator Author

cszsol commented Nov 8, 2024

This PR has to be merged first
#32

WonderPG
WonderPG reviewed Nov 21, 2024
View reviewed changes
Copy link
Contributor

@WonderPG WonderPG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of comments, thank you !

swarm_copy_tests/conftest.py Outdated Show resolved Hide resolved
swarm_copy_tests/conftest.py Outdated Show resolved Hide resolved
swarm_copy_tests/conftest.py Outdated Show resolved Hide resolved
.github/workflows/changelog.yml Outdated Show resolved Hide resolved
swarm_copy/tools/bluenaas_memodel_getall.py Outdated Show resolved Hide resolved
swarm_copy/tools/bluenaas_memodel_getone.py Outdated Show resolved Hide resolved
swarm_copy_tests/tools/test_literature_search_tool.py Outdated Show resolved Hide resolved
@kanesoban kanesoban mentioned this pull request Dec 5, 2024
Merged
@BoBer78
Copy link
Contributor

BoBer78 commented Dec 18, 2024

There is one test missing in test_get_morpho_tool (the one testing the query).
Appart from that there are a couple issues with the CI not passing because of the recent changes. After that it should be good to go !

@WonderPG WonderPG merged commit bc1ac9b into main Dec 19, 2024
5 checks passed
@WonderPG WonderPG deleted the tool_unit_tests branch December 19, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WonderPG WonderPG WonderPG left review comments

@kanesoban kanesoban kanesoban left review comments

@BoBer78 BoBer78 BoBer78 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cszsol @BoBer78 @kanesoban @WonderPG