Remove duplicates of unifying test API. #990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1uc
force-pushed
the
1uc/cleanup-tests
branch
2 times, most recently
from
cfd5db5 to
646d421
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #990 +/- ##
==========================================
- Coverage 86.31% 86.28% -0.03%
==========================================
Files 92 92
Lines 5919 5908 -11
==========================================
- Hits 5109 5098 -11
Misses 810 810 ☔ View full report in Codecov by Sentry. |
matz-e
reviewed
May 6, 2024
matz-e
approved these changes
May 6, 2024
There's three copies of unifying API for DataSet and Attribute. This removes one copy.
This removes a second copy of the unifying API used for testing `Attribute`s and `DataSet`s.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's three copies of unifying API for DataSet and Attribute. This
removes two copies.