Improve details::Boolean compatibility checks.
#880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSVC complained (and I believe errored out) about the previous variation. This variation is more blunt about comparing bytes. |
Instead of comparing values, use `std::memcmp` to compare bytes.
1uc
force-pushed
the
1uc/better-bool-test
branch
from
dea74ea to
c6d1194
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #880 +/- ##
==========================================
+ Coverage 84.94% 84.97% +0.02%
==========================================
Files 71 71
Lines 5109 5118 +9
==========================================
+ Hits 4340 4349 +9
Misses 769 769 ☔ View full report in Codecov by Sentry. |
matz-e
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of comparing values, use
std::memcmpto compare bytes.