Check ctest output for HDF5-DIAG.
#858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should reveal the bug fixed by #856. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #858 +/- ##
=======================================
Coverage 84.74% 84.74%
=======================================
Files 70 70
Lines 5061 5061
=======================================
Hits 4289 4289
Misses 772 772 ☔ View full report in Codecov by Sentry. |
1uc
force-pushed
the
1uc/detect-hdf5-diag
branch
2 times, most recently
from
0508f95 to
63482e0
Compare
1uc
force-pushed
the
1uc/detect-hdf5-diag
branch
from
63482e0 to
91fd82f
Compare
HDF5 errors that aren't promoted to an exception by HighFive will simply print an error message. This means that tests can pass even if there are HDF5 errors. This will run the tests with `ctest --verbose` and check that the output doesn't contain `"HDF5-DIAG"`.
1uc
force-pushed
the
1uc/detect-hdf5-diag
branch
from
91fd82f to
2bf93db
Compare
matz-e
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HDF5 errors that aren't promoted to an exception by HighFive will simply print an error message. This means that tests can pass even if there are HDF5 errors. This will run the tests with
ctest --verboseand check that the output doesn't contain"HDF5-DIAG".