Remove read(T*, ...).

BlueBrain · Feb 7, 2024 · fa7cd44 · fa7cd44
1 parent 6ab3f68
commit fa7cd44
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 64 deletions.
diff --git a/include/highfive/H5Attribute.hpp b/include/highfive/H5Attribute.hpp
@@ -113,16 +113,6 @@ class Attribute: public Object, public PathTraits<Attribute> {
     template <typename T>
     void read(T& array) const;
 
-    /// \brief Read the attribute into a pre-allocated buffer.
-    /// \deprecated use `read(T&` or `read_raw`.
-    template <typename T>
-    void read(T* array, const DataType& mem_datatype) const;
-
-    /// \brief Read the attribute into a buffer.
-    /// \deprecated use `read(T&` or `read_raw`.
-    template <typename T>
-    void read(T* array) const;
-
     /// \brief Read the attribute into a pre-allocated buffer.
     /// \param array A pointer to the first byte of sufficient pre-allocated memory.
     /// \param mem_datatype The DataType of the array.

diff --git a/include/highfive/bits/H5Attribute_misc.hpp b/include/highfive/bits/H5Attribute_misc.hpp
@@ -101,11 +101,6 @@ inline void Attribute::read(T& array) const {
     }
 }
 
-template <typename T>
-inline void Attribute::read(T* array, const DataType& mem_datatype) const {
-    read_raw(array, mem_datatype);
-}
-
 template <typename T>
 inline void Attribute::read_raw(T* array, const DataType& mem_datatype) const {
     static_assert(!std::is_const<T>::value,
@@ -114,11 +109,6 @@ inline void Attribute::read_raw(T* array, const DataType& mem_datatype) const {
     detail::h5a_read(getId(), mem_datatype.getId(), static_cast<void*>(array));
 }
 
-template <typename T>
-inline void Attribute::read(T* array) const {
-    read_raw(array);
-}
-
 template <typename T>
 inline void Attribute::read_raw(T* array) const {
     using element_type = typename details::inspector<T>::base_type;

diff --git a/include/highfive/bits/H5Slice_traits.hpp b/include/highfive/bits/H5Slice_traits.hpp
@@ -303,36 +303,6 @@ class SliceTraits {
     template <typename T>
     void read(T& array, const DataTransferProps& xfer_props = DataTransferProps()) const;
 
-    ///
-    /// Read the entire dataset into a raw buffer
-    ///
-    /// \deprecated Use `read_raw` instead.
-    ///
-    /// No dimensionality checks will be performed, it is the user's
-    /// responsibility to ensure that the right amount of space has been
-    /// allocated.
-    /// \param array: A buffer containing enough space for the data
-    /// \param dtype: The datatype of elements of the in memory buffer.
-    /// \param xfer_props: Data Transfer properties
-    template <typename T>
-    void read(T* array,
-              const DataType& dtype,
-              const DataTransferProps& xfer_props = DataTransferProps()) const;
-
-    ///
-    /// Read the entire dataset into a raw buffer
-    ///
-    /// \deprecated Use `read_raw` instead.
-    ///
-    /// Same as `read(T*, const DataType&, const DataTransferProps&)`. However,
-    /// this overload deduces the HDF5 datatype of the element of `array` from
-    /// `T`. Note, that the file datatype is already fixed.
-    ///
-    /// \param array: A buffer containing enough space for the data
-    /// \param xfer_props: Data Transfer properties
-    template <typename T>
-    void read(T* array, const DataTransferProps& xfer_props = DataTransferProps()) const;
-
     ///
     /// Read the entire dataset into a raw buffer
     ///

diff --git a/include/highfive/bits/H5Slice_traits_misc.hpp b/include/highfive/bits/H5Slice_traits_misc.hpp
@@ -207,20 +207,6 @@ inline void SliceTraits<Derivate>::read(T& array, const DataTransferProps& xfer_
     }
 }
 
-template <typename Derivate>
-template <typename T>
-inline void SliceTraits<Derivate>::read(T* array,
-                                        const DataType& mem_datatype,
-                                        const DataTransferProps& xfer_props) const {
-    read_raw(array, mem_datatype, xfer_props);
-}
-
-template <typename Derivate>
-template <typename T>
-inline void SliceTraits<Derivate>::read(T* array, const DataTransferProps& xfer_props) const {
-    read_raw(array, xfer_props);
-}
-
 
 template <typename Derivate>
 template <typename T>