This repository has been archived by the owner on Mar 20, 2023. It is now read-only.
CMake build options refactoring for Makefile #455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* move all makefile related options into single file MakefileBuildOptions.cmake * remove all option processing from extra/CMakeLists.txt * fix with neuron linking : type CN_PGI_ACC_FLAGS -> PGI_ACC_FLAGS
|
Retest this please |
2 similar comments
|
Retest this please |
|
Retest this please |
pramodk
force-pushed
the
pramodk/build-opts
branch
from
a5c182d to
38323e4
Compare
pramodk
force-pushed
the
pramodk/build-opts
branch
from
bc6f17c to
d73f0f1
Compare
pramodk
force-pushed
the
pramodk/build-opts
branch
from
d73f0f1 to
631f04c
Compare
* PG_ACC_BUGS was added when we saw bugs with PGI compiler
version 16.3
* Except the case of union, no more real buggy scenario exists
* So remove all usages of PG_ACC_BUGS
* Remove some hardcoded ion array size by const variable
|
retest this please |
|
Ignoring Simulation stack because it's failing with the latest Spack related errors. |
pramodk
added a commit
to neuronsimulator/nrn
that referenced
this pull request
Nov 2, 2022
…BlueBrain/CoreNeuron#455) * CMake build options refactoring for Makefile * move all makefile related options into single file MakefileBuildOptions.cmake * remove all option processing from extra/CMakeLists.txt * fix with neuron linking : type CN_PGI_ACC_FLAGS -> PGI_ACC_FLAGS * Use PGI archive module because of issue with latest NVHPC modules * fix ISPC build issue and nrnivmodl-core failure on OSX * Avoid P2 UC2 ndoes as GPFS is not mounted (HELP-13390) * Use spack branch only if specified * Remove use of PG_ACC_BUGS * PG_ACC_BUGS was added when we saw bugs with PGI compiler version 16.3 * Except the case of union, no more real buggy scenario exists * So remove all usages of PG_ACC_BUGS * Remove some hardcoded ion array size by const variable * update mod2c to master * mods files and cpp translated files are in same x86_64/corenrn/mod2c directory CoreNEURON Repo SHA: BlueBrain/CoreNeuron@d4ed738
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to simplify makefile generation with multiple targets (#442)
this PR refactor some of the CMake flags handling:
How to test this?
Usual CMake build options; no changes in CMake
CI_BRANCHES:NEURON_BRANCH=master,SPACK_BRANCH=bbpv-2021-01