Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid accessing private hoc attribute in core.py #130

Merged
merged 3 commits into from
Feb 14, 2024
Merged

avoid accessing private hoc attribute in core.py #130

merged 3 commits into from
Feb 14, 2024

Conversation

anilbey
Copy link
Contributor

@anilbey anilbey commented Feb 13, 2024

  • removes the explicit statement of setting the gid of hoc. That is already done in: neuron_template.get_cell(template_format, self.cell_id.id, emodel_properties).
  • add test for loading a bpo hoc template

@anilbey anilbey marked this pull request as ready for review February 14, 2024 09:57
@codecov-commenter
Copy link

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (d7a5240) 85.30% compared to head (e82571d) 85.27%.
Report is 3 commits behind head on main.

Files Patch % Lines
bluecellulab/circuit/config/sections.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #130      +/-   ##
==========================================
- Coverage   85.30%   85.27%   -0.04%     
==========================================
  Files          80       80              
  Lines        5404     5413       +9     
==========================================
+ Hits         4610     4616       +6     
- Misses        794      797       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@darshanmandge darshanmandge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.This works with the template now!

Do you also want to put an examples of the latest bpo template and the bpem templates so that we are sure bluecellulab works with all the templates?

@anilbey
Copy link
Contributor Author

anilbey commented Feb 14, 2024

Do you also want to put an examples of the latest bpo template and the bpem templates so that we are sure bluecellulab works with all the templates?

Actually the latest templates are updated to have bluecellulab/neurodamus support. They are similar to the ones coming after bluepymm. The tests are supporting those already.

@anilbey
Copy link
Contributor Author

anilbey commented Feb 14, 2024

Thanks @darshanmandge . For the .h5 morphologies the work will continue at #131.

@anilbey anilbey merged commit e2cf209 into main Feb 14, 2024
10 checks passed
@anilbey anilbey deleted the hoc-access branch February 14, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants