Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reqwest blocking feature #5

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ColinRhys
Copy link

Pull Request for Issue - Allow library user to use the library synchronously
This pull request introduces the "blocking" feature to the festivus crate, allowing users to opt for synchronous execution of the calculate_fee function.

Changes Made:

  • Implemented a synchronous version of the calculate_fee function, which can be activated using the "blocking" feature flag.
  • Maintained the same function signature for both asynchronous and synchronous versions of calculate_fee. The appropriate version is determined by the feature flag:
  • #[cfg(not(feature = "blocking"))] for the asynchronous (default) version.
  • #[cfg(feature = "blocking")] for the synchronous version.
  • Updated the reqwest dependency in Cargo.toml to include the "blocking" feature.
  • Added new tests to ensure the functionality of the synchronous version of calculate_fee.
  • Updated the README file to include instructions on how to use the new "blocking" feature.

Branching Strategy:
Branched off from the branch containing changes to the calculate_fee function signature in the other pull request I created to maintain consistency and avoid merge conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant