Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG-11612 use FromBase58 to sign with key from path #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dannydeezy
Copy link
Contributor

@dannydeezy dannydeezy commented Mar 25, 2019

Motivation

https://bitgoinc.atlassian.net/browse/BG-11612

Overview Of Changes

When a user signs, we expect them to enter a key of the xprv format. However this line I'm changing is incorrect as its expecting a hex-formatted key

@dannydeezy dannydeezy changed the title BG-11612 use FromBase58 BG-11612 use FromBase58 to sign with key from path Mar 29, 2019
@dannydeezy dannydeezy requested a review from typokign April 12, 2019 22:43
@cooncesean
Copy link
Contributor

@dannybitgo you need eyes on this? Is this ready for review?

@dannydeezy
Copy link
Contributor Author

@dannybitgo you need eyes on this? Is this ready for review?

yes this does need a review

@dannydeezy
Copy link
Contributor Author

and its ready

@cooncesean
Copy link
Contributor

This PR needs three things:

  1. Testing steps; what are the manual steps we can take in order to test the unhappy path (basically, the issue you are fixing w/ this PR)?
  2. Testing steps we can take to test the patch and the happy path.
  3. Unit tests to cover the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants