feat(sdk-core): add skipReceiveAddress optional parameter IWallets #5373
+51
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ist in SDK TICKET: WP-1271
zahin-mohammad
requested changes
Jan 15, 2025
| @@ -166,6 +166,7 @@ export interface ListWalletOptions extends PaginationOptions { | |||
| skip?: number; | |||
| getbalances?: boolean; | |||
| allTokens?: boolean; | |||
| skipReceiveAddress?: boolean; | |||
There was a problem hiding this comment.
Please add a jsdoc for this.
Can you also create a test showing the api gets called with this new field?
There was a problem hiding this comment.
added test case and jsdoc
kisslove-dewangan
force-pushed
the
WP-1271-get-wallet-list-sdk-changes
branch
from
9cf92e2 to
5cc023a
Compare
…veAddress param TICKET: WP-1271
…ceiveAddress param TICKET: WP-1271
pengyuc-bitgo
approved these changes
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: WP-1271