chore(sdk-coin-tao): add sdk skeleton #5360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvrakesh06
force-pushed
the
WIN-4293
branch
7 times, most recently
from
95d9c87 to
d618991
Compare
zahin-mohammad
previously approved these changes
Jan 13, 2025
modules/sdk-coin-tao/README.md
Outdated
|
|
||
| const sdk = new BitGoAPI(); | ||
|
|
||
| sdk.register('apt', Apt.createInstance); |
There was a problem hiding this comment.
wrong coin in this register function?
alebusse
previously approved these changes
Jan 13, 2025
Comment on lines
41
to
42
| "@bitgo/sdk-core": "^28.19.0", | ||
| "@bitgo/statics": "^50.18.0" |
DinshawKothari
previously approved these changes
Jan 13, 2025
modules/sdk-coin-tao/README.md
Outdated
|
|
||
| ```javascript | ||
| import { BitGoAPI } from '@bitgo/sdk-api'; | ||
| import { Apt } from '@bitgo/sdk-coin-tao'; |
There was a problem hiding this comment.
wrong coin here too.
modules/sdk-coin-tao/README.md
Outdated
|
|
||
| const sdk = new BitGoAPI(); | ||
|
|
||
| sdk.register('apt', Apt.createInstance); |
nvrakesh06
dismissed stale reviews from DinshawKothari, alebusse, and zahin-mohammad
via
4c37659
alebusse
approved these changes
Jan 13, 2025
zahin-mohammad
approved these changes
Jan 13, 2025
hitansh-madan
approved these changes
Jan 15, 2025
sijuu
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-4293