Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sdk-coin-ada): increase min amount to 1.5 ADA for token consolid… #4054

Merged
merged 1 commit into from
Nov 10, 2023

Conversation

Vijay-Jagannathan
Copy link
Contributor

@Vijay-Jagannathan Vijay-Jagannathan commented Nov 9, 2023

Ticket: WIN-736

Context

Minimum balance to be sent in a token transaction is ~ 1.15 ADA. Increasing ADA minimum amount in the tx builder to 1.5 for token consolidation to avoid any issues

@@ -282,7 +282,7 @@ export abstract class TransactionBuilder extends BaseTransactionBuilder {
// support for multi-asset consolidation
if (this._multiAssets !== undefined) {
const totalNumberOfAssets = CardanoWasm.BigNum.from_str(this._multiAssets.length.toString());
const minAmountNeededForOneAssetOutput = CardanoWasm.BigNum.from_str('1000000');
const minAmountNeededForOneAssetOutput = CardanoWasm.BigNum.from_str('1500000');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if theres more than one asset?

Copy link
Contributor Author

@Vijay-Jagannathan Vijay-Jagannathan Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We construct a separate output for each asset/token in the UTXO, so each asset output will have 1.5 based on the new minimum amount

@Vijay-Jagannathan Vijay-Jagannathan marked this pull request as ready for review November 9, 2023 16:09
@Vijay-Jagannathan Vijay-Jagannathan requested a review from a team as a code owner November 9, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants