Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to node 20 #4036

Merged
merged 7 commits into from
Nov 2, 2023
Merged

Upgrade to node 20 #4036

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b82437d
chore: update engines to suport node20
andrew-scott-fischer Nov 1, 2023
ea148d8
ci: add node20 to ci
andrew-scott-fischer Nov 1, 2023
68a755c
chore: add node version to node_modules cache key
andrew-scott-fischer Nov 1, 2023
8c07e7e
chore: update @types/node
andrew-scott-fischer Nov 2, 2023
b303e4e
chore: update .nvmrc
andrew-scott-fischer Nov 2, 2023
010e223
docs: update docs to state node20 is supported
andrew-scott-fischer Nov 2, 2023
1daf891
chore: update yarn.lock
andrew-scott-fischer Nov 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ jobs:

strategy:
matrix:
node-version: [16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -48,7 +48,7 @@ jobs:
path: |
node_modules
modules/*/node_modules
key: ${{ runner.os }}-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('package.json') }}
key: ${{ runner.os }}-node${{matrix.node-version}}-${{ hashFiles('yarn.lock') }}-${{ hashFiles('tsconfig.packages.json') }}-${{ hashFiles('package.json') }}

- name: Install Packages
if: steps.lerna-cache.outputs.cache-hit != 'true' || contains( github.event.pull_request.labels.*.name, 'SKIP_CACHE')
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16
20
3 changes: 2 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ BitGoJS currently provides support for the following Node versions per package.j

```
"engines": {
"node": ">=16 <19",
"node": ">=16 <21",
"npm": ">=3.10.10"
}
```
Expand All @@ -63,6 +63,7 @@ As each Node LTS version reaches its end-of-life we will exclude that version fr

- `16`
- `18`
- `20`

JavaScript package managers should allow you to install this package with any version of Node, with, at most, a warning if your version of Node does not fall within the range specified by our node engines property. If you encounter issues installing this package on a supported version of Node, please report the issue to us.

Expand Down
2 changes: 1 addition & 1 deletion modules/abstract-cosmos/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/abstract-eth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/abstract-utxo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/account-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "ISC",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"dependencies": {
"@bitgo/sdk-coin-algo": "^1.7.0",
Expand Down
2 changes: 1 addition & 1 deletion modules/bitgo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
},
"license": "Apache-2.0",
"engines": {
"node": ">=16 <19",
"node": ">=16 <21",
"npm": ">=3.10.10"
},
"scripts": {
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-ada/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-algo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-arbeth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-atom/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-avaxc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-avaxp/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"lint-staged": {
"*.{js,ts}": [
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bch/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bcha/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bera/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bld/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bsc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-bsv/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-btc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-btg/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-celo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-coreum/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-cspr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-dash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-doge/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-dot/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-eos/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-etc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-eth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-eth2/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-ethw/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-hash/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-hbar/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-injective/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-islm/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-ltc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-near/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-opeth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-osmo/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-polygon/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
2 changes: 1 addition & 1 deletion modules/sdk-coin-rbtc/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"author": "BitGo SDK Team <[email protected]>",
"license": "MIT",
"engines": {
"node": ">=16 <19"
"node": ">=16 <21"
},
"repository": {
"type": "git",
Expand Down
Loading