-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk-coin-ton): add missing tslib dep #4035
Conversation
New dependencies detected. Learn more about Socket for GitHub ↗︎
|
c61f1b2
to
c7f0d17
Compare
🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎ To accept the risk, merge this PR and you will not be notified again.
Next stepsWhat is an invalid package.json?Package has an invalid package.json and can cause installation problems if you try to use it. Fix syntax errors in the invalid package.json and publish a new version with a valid package.json. Consumers can use npm overrides to force a version that does not have this problem if one exists. Take a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Github action step seems to be failing as this package is not used in the code, the failing check doesn't seem optional
I'm not sure why it thinks that. We found an issue with hsm-api repo, where pulling in |
moving to draft until CI is fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flush
this is currently causing us issues with HSM-api deployment on HSM servers (if NODE_ENV is set to anything other than default / development, there is issues). if this is just blocked due to CI bugs, can DevOps force merge this? I'm taking this out of draft due to the urgency of this. |
closing this PR, as https://github.com/BitGo/hsm-api/pull/466 fixes our issue. |
Ticket: HSM-213