Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk-coin-ton): add missing tslib dep #4035

Closed
wants to merge 1 commit into from
Closed

Conversation

Logicwax
Copy link
Contributor

@Logicwax Logicwax commented Nov 1, 2023

Ticket: HSM-213

@Logicwax Logicwax requested a review from a team as a code owner November 1, 2023 23:36
Copy link

socket-security bot commented Nov 1, 2023

New dependencies detected. Learn more about Socket for GitHub ↗︎

Packages Version New capabilities Transitives Size Publisher
@bitgo/sdk-coin-btc 1.7.13 None +2 82 kB alebusse
@bitgo/sdk-coin-xrp 1.7.13 None +4 488 kB alebusse
@bitgo/sdk-coin-xlm 2.5.0 None +4 2.05 MB alebusse
@types/morgan 1.9.4 None +0 13.8 kB types
@types/supertest 2.0.12 None +0 7.48 kB types
sinon 6.3.5 eval +0 4.6 MB mrgnrdrck

@Logicwax Logicwax requested review from a team as code owners November 1, 2023 23:58
Copy link

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Issue Package Version Note Source
Invalid package.json postcss-logical 5.0.4
Invalid package.json postcss-overflow-shorthand 3.0.4

Next steps

What is an invalid package.json?

Package has an invalid package.json and can cause installation problems if you try to use it.

Fix syntax errors in the invalid package.json and publish a new version with a valid package.json. Consumers can use npm overrides to force a version that does not have this problem if one exists.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] bar@* or ignore all packages with @SocketSecurity ignore-all

Copy link
Contributor

@gianchandania gianchandania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github action step seems to be failing as this package is not used in the code, the failing check doesn't seem optional

@Logicwax
Copy link
Contributor Author

Logicwax commented Nov 2, 2023

Github action step seems to be failing as this package is not used in the code, the failing check doesn't seem optional

I'm not sure why it thinks that. We found an issue with hsm-api repo, where pulling in @bitgo-beta#sdk-coin-ton caused us to have missing tslib module errors. A run of yarn why tslib even states "Hoisted from "@bitgo-beta#sdk-coin-ton#tonweb#isomorphic-webcrypto"

@OttoAllmendinger OttoAllmendinger marked this pull request as draft November 2, 2023 12:23
@OttoAllmendinger
Copy link
Contributor

moving to draft until CI is fixed

Copy link
Contributor

@OttoAllmendinger OttoAllmendinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flush

@Logicwax
Copy link
Contributor Author

Logicwax commented Nov 4, 2023

moving to draft until CI is fixed

this is currently causing us issues with HSM-api deployment on HSM servers (if NODE_ENV is set to anything other than default / development, there is issues). if this is just blocked due to CI bugs, can DevOps force merge this? I'm taking this out of draft due to the urgency of this.

@Logicwax Logicwax marked this pull request as ready for review November 4, 2023 01:44
@Logicwax
Copy link
Contributor Author

Logicwax commented Nov 7, 2023

closing this PR, as https://github.com/BitGo/hsm-api/pull/466 fixes our issue.

@Logicwax Logicwax closed this Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants