feat(sdk-coin-sol): add sol token recovery support #4034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alia-bitgo
force-pushed
the
WP-930-add-sol-token-recovery-support
branch
from
52ded52 to
ddc96b5
Compare
alia-bitgo
force-pushed
the
WP-930-add-sol-token-recovery-support
branch
6 times, most recently
from
fbc1d2e to
a03b8e8
Compare
rlutzbitgo
previously approved these changes
Nov 20, 2023
zahin-mohammad
requested changes
Nov 20, 2023
alia-bitgo
force-pushed
the
WP-930-add-sol-token-recovery-support
branch
3 times, most recently
from
fcddefc to
5157d36
Compare
alia-bitgo
force-pushed
the
WP-930-add-sol-token-recovery-support
branch
from
5157d36 to
8a46e48
Compare
zahin-mohammad
approved these changes
Nov 23, 2023
| @@ -572,6 +600,38 @@ export class Sol extends BaseCoin { | |||
| }; | |||
| } | |||
|
|
|||
| protected async getTokenAccountsByOwner(pubKey = ''): Promise<[] | TokenAccount[]> { | |||
There was a problem hiding this comment.
Should an empty pubkey be valid for this?
rlutzbitgo
approved these changes
Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding in token recovery support for solana. This has been tested e2e for both cold and hot wallets.
TICKET: WP-930