fix(sdk-coin-ada): add multi-asset to init builder flow #4033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| asset.insert(assetName, quantity!); | ||
| multiAsset.insert(policyId, asset); | ||
| txOutputAmountBuilder = txOutputAmountBuilder.with_coin_and_asset(outputAmount, multiAsset); | ||
| const txOutput = txOutputAmountBuilder.build(); |
There was a problem hiding this comment.
Small question, why are we just initializing the txOutputAmountBuilder here? is it not used in any other part of code?
There was a problem hiding this comment.
Otherwise looks fine to me
There was a problem hiding this comment.
We do use it another place (when we go through the consolidation builder - #3994), but that flow is not related to the parseTransaction flow that this PR deals with
rushilbg
approved these changes
Nov 1, 2023
margueriteblair
approved these changes
Nov 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: WIN-736
Context
We recently added the following PRs for ADA token consolidation support:
While testing the ADA token consolidation flow, we found that in the parseTransaction method that's used in WP, we don't have the asset data in the tx. This is due to the fact that, asset data is not added in outputs of the
initBuildermethod. And when we build the transaction, we weren't adding the assets to the transaction outputsThis PR ensures that the tx data contains outputs, along with the asset data in them, especially in the parseTransaction flow