Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): use BuildParams.encode when consolidating unspents #4023

Merged
merged 1 commit into from
Nov 2, 2023
Merged

fix(core): use BuildParams.encode when consolidating unspents #4023

merged 1 commit into from
Nov 2, 2023

Conversation

OttoAllmendinger
Copy link
Contributor

Issue: BTC-576

@OttoAllmendinger OttoAllmendinger marked this pull request as ready for review October 27, 2023 16:02
@OttoAllmendinger OttoAllmendinger requested review from a team as code owners October 27, 2023 16:02
rushilbg
rushilbg previously requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@rushilbg rushilbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit linter failing, should say sdk-core.

@OttoAllmendinger OttoAllmendinger force-pushed the BTC-576.approve-consolidation branch from d0bf6dd to ef5da11 Compare October 30, 2023 14:42
@davidkaplanbitgo
Copy link
Contributor

Dependency audit is failing

@davidkaplanbitgo davidkaplanbitgo force-pushed the BTC-576.approve-consolidation branch from ef5da11 to f83f096 Compare November 1, 2023 11:56
@davidkaplanbitgo
Copy link
Contributor

Rebased to fix audit failures

@OttoAllmendinger OttoAllmendinger dismissed rushilbg’s stale review November 2, 2023 07:36

commit title is fixed nwo

@OttoAllmendinger OttoAllmendinger merged commit afc1671 into master Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidkaplanbitgo davidkaplanbitgo davidkaplanbitgo approved these changes

@margueriteblair margueriteblair margueriteblair approved these changes

@rushilbg rushilbg Awaiting requested review from rushilbg

@rlutzbitgo rlutzbitgo Awaiting requested review from rlutzbitgo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@OttoAllmendinger @davidkaplanbitgo @margueriteblair @rlutzbitgo @rushilbg