feat(utxo-bin): add new command convertTx #4017
Closed
+245
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
OttoAllmendinger
commented
Oct 25, 2023
OttoAllmendinger
commented
- feat(blockapis): add fetchPrevTxBuffers
- feat(utxo-bin): use strict mode
- feat(utxo-bin): add new command convertTx
OttoAllmendinger
changed the title
OttoAllmendinger
changed the title
rushilbg
reviewed
Oct 26, 2023
OttoAllmendinger
force-pushed
the
BTC-428.convert-psbt
branch
from
461fbf4 to
a278f18
Compare
rushilbg
approved these changes
Oct 30, 2023
| api: UtxoApi, | ||
| _network: utxolib.Network | ||
| ): Promise<Buffer[]> { | ||
| return mapInputs(toOutPoints(ins), async (txid) => Buffer.from(await api.getTransactionHex(txid), 'hex')); |
There was a problem hiding this comment.
It's unusual seeing here an async function being passed this way, but I like it!
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
|
This PR was closed because it has been stalled for 10 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.