Skip to content

Commit

Permalink
refactor(abstract-eth): delete mpc related classes
Browse files Browse the repository at this point in the history
  • Loading branch information
gianchandania committed Oct 31, 2023
1 parent e29fe5a commit 10aa1dc
Show file tree
Hide file tree
Showing 7 changed files with 44 additions and 46 deletions.
17 changes: 0 additions & 17 deletions modules/abstract-eth/src/abstractEthLikeMPCCoin.ts

This file was deleted.

17 changes: 0 additions & 17 deletions modules/abstract-eth/src/ethLikeMPCToken.ts

This file was deleted.

2 changes: 0 additions & 2 deletions modules/abstract-eth/src/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,4 @@
export * from './abstractEthLikeCoin';
export * from './ethLikeToken';
export * from './abstractEthLikeMPCCoin';
export * from './ethLikeMPCToken';
export * from './lib';
export * from './abstractEthLikeNewCoins';
11 changes: 8 additions & 3 deletions modules/sdk-coin-arbeth/src/arbethToken.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
/**
* @prettier
*/
import { EthLikeTokenConfig } from '@bitgo/statics';
import { EthLikeTokenConfig, coins } from '@bitgo/statics';
import { BitGoBase, CoinConstructor, NamedCoinConstructor } from '@bitgo/sdk-core';
import { CoinNames, EthLikeMPCToken } from '@bitgo/abstract-eth';
import { CoinNames, EthLikeToken } from '@bitgo/abstract-eth';

import { TransactionBuilder } from './lib';
export { EthLikeTokenConfig };

export class ArbethToken extends EthLikeMPCToken {
export class ArbethToken extends EthLikeToken {
public readonly tokenConfig: EthLikeTokenConfig;
static coinNames: CoinNames = {
Mainnet: 'arbeth',
Expand All @@ -24,6 +25,10 @@ export class ArbethToken extends EthLikeMPCToken {
return super.createTokenConstructors(ArbethToken.coinNames);
}

protected getTransactionBuilder(): TransactionBuilder {
return new TransactionBuilder(coins.get(this.getBaseChain()));
}

getFullName(): string {
return 'Arbeth Token';
}
Expand Down
16 changes: 13 additions & 3 deletions modules/sdk-coin-bsc/src/bsc.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { BaseCoin, BitGoBase } from '@bitgo/sdk-core';
import { BaseCoin, BitGoBase, MPCAlgorithm } from '@bitgo/sdk-core';
import { BaseCoin as StaticsBaseCoin, coins } from '@bitgo/statics';
import { AbstractEthLikeMPCCoin } from '@bitgo/abstract-eth';
import { AbstractEthLikeCoin } from '@bitgo/abstract-eth';
import { TransactionBuilder as EthTransactionBuilder } from '@bitgo/sdk-coin-eth';
import { TransactionBuilder } from './lib';

export class Bsc extends AbstractEthLikeMPCCoin {
export class Bsc extends AbstractEthLikeCoin {
protected constructor(bitgo: BitGoBase, staticsCoin?: Readonly<StaticsBaseCoin>) {
super(bitgo, staticsCoin);
}
Expand All @@ -21,4 +21,14 @@ export class Bsc extends AbstractEthLikeMPCCoin {
allowsAccountConsolidations(): boolean {
return true;
}

/** @inheritDoc */
supportsTss(): boolean {
return true;
}

/** @inheritDoc */
getMPCAlgorithm(): MPCAlgorithm {
return 'ecdsa';
}
}
23 changes: 19 additions & 4 deletions modules/sdk-coin-bsc/src/bscToken.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,14 @@
* @prettier
*/

import { EthLikeTokenConfig } from '@bitgo/statics';
import { BitGoBase, CoinConstructor, NamedCoinConstructor } from '@bitgo/sdk-core';
import { CoinNames, EthLikeMPCToken } from '@bitgo/abstract-eth';
import { EthLikeTokenConfig, coins } from '@bitgo/statics';
import { BitGoBase, CoinConstructor, NamedCoinConstructor, MPCAlgorithm } from '@bitgo/sdk-core';
import { CoinNames, EthLikeToken } from '@bitgo/abstract-eth';
import { TransactionBuilder } from './lib';

export { EthLikeTokenConfig };

export class BscToken extends EthLikeMPCToken {
export class BscToken extends EthLikeToken {
public readonly tokenConfig: EthLikeTokenConfig;
static coinNames: CoinNames = {
Mainnet: 'bsc',
Expand All @@ -25,6 +26,20 @@ export class BscToken extends EthLikeMPCToken {
return super.createTokenConstructors(BscToken.coinNames);
}

protected getTransactionBuilder(): TransactionBuilder {
return new TransactionBuilder(coins.get(this.getBaseChain()));
}

/** @inheritDoc */
supportsTss(): boolean {
return true;
}

/** @inheritDoc */
getMPCAlgorithm(): MPCAlgorithm {
return 'ecdsa';
}

getFullName(): string {
return 'Bsc Token';
}
Expand Down
4 changes: 4 additions & 0 deletions modules/sdk-coin-bsc/src/lib/transactionBuilder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,8 @@ export class TransactionBuilder extends EthTransactionBuilder {
publicKey(key: string): void {
this._sourceKeyPair = new KeyPair({ pub: key });
}

protected getContractData(addresses: string[]): string {
throw new Error('Method not implemented.');
}
}

0 comments on commit 10aa1dc

Please sign in to comment.