refactor(abstract-eth): move methods to abstract-eth

WIN-1012 TICKET: WIN-1012
BitGo · Nov 7, 2023 · 0c0bc80 · 0c0bc80
1 parent 05695da
commit 0c0bc80
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 45 deletions.
diff --git a/modules/abstract-eth/package.json b/modules/abstract-eth/package.json
@@ -48,6 +48,9 @@
     "ethereumjs-abi": "^0.6.5",
     "ethereumjs-util": "7.1.5",
     "ethers": "^5.1.3",
-    "lodash": "4.17.21"
+    "lodash": "4.17.21",
+    "keccak": "^3.0.3",
+    "secp256k1": "5.0.0",
+    "@bitgo/sdk-lib-mpc": "^8.15.0"
   }
 }
diff --git a/modules/sdk-coin-eth/package.json b/modules/sdk-coin-eth/package.json
@@ -42,15 +42,11 @@
   "dependencies": {
     "@bitgo/abstract-eth": "^1.6.0",
     "@bitgo/sdk-core": "^8.26.0",
-    "@bitgo/sdk-lib-mpc": "^8.15.0",
     "@bitgo/statics": "^29.0.0",
     "@bitgo/utxo-lib": "^9.16.0",
-    "@ethereumjs/common": "^2.6.5",
     "@ethereumjs/tx": "^3.3.0",
     "@ethereumjs/util": "8.0.3",
     "@metamask/eth-sig-util": "^5.0.2",
-    "bignumber.js": "^9.0.0",
-    "bn.js": "^5.2.1",
     "ethereumjs-abi": "^0.6.5",
     "ethereumjs-util": "7.1.5",
     "ethers": "^5.1.3",

diff --git a/modules/sdk-coin-ethw/src/ethw.ts b/modules/sdk-coin-ethw/src/ethw.ts
@@ -1,6 +1,5 @@
 import request from 'superagent';
 
-import BigNumber from 'bignumber.js';
 import { BN } from 'ethereumjs-util';
 
 import {
@@ -10,13 +9,11 @@ import {
   KeyPair,
   ParsedTransaction,
   ParseTransactionOptions,
-  TransactionExplanation,
   VerifyAddressOptions,
   VerifyTransactionOptions,
 } from '@bitgo/sdk-core';
 import { BaseCoin as StaticsBaseCoin, coins } from '@bitgo/statics';
 import { Eth, optionalDeps, TransactionBuilder } from '@bitgo/sdk-coin-eth';
-import { ExplainTransactionOptions } from '@bitgo/abstract-eth';
 
 type FullNodeResponseBody = {
   jsonrpc: string;
@@ -123,40 +120,6 @@ export class Ethw extends Eth {
     return response.body;
   }
 
-  /**
-   * Explain a transaction from txHex
-   * @param params The options with which to explain the transaction
-   */
-  async explainTransaction(params: ExplainTransactionOptions): Promise<TransactionExplanation> {
-    const txHex = params.txHex || (params.halfSigned && params.halfSigned.txHex);
-    if (!txHex || !params.feeInfo) {
-      throw new Error('missing explain tx parameters');
-    }
-    const txBuilder = this.getTransactionBuilder();
-    txBuilder.from(txHex);
-    const tx = await txBuilder.build();
-    const outputs = tx.outputs.map((output) => {
-      return {
-        address: output.address,
-        amount: output.value,
-      };
-    });
-
-    const displayOrder = ['id', 'outputAmount', 'changeAmount', 'outputs', 'changeOutputs', 'fee'];
-
-    return {
-      displayOrder,
-      id: tx.id,
-      outputs: outputs,
-      outputAmount: outputs
-        .reduce((accumulator, output) => accumulator.plus(output.amount), new BigNumber('0'))
-        .toFixed(0),
-      changeOutputs: [], // account based does not use change outputs
-      changeAmount: '0', // account base does not make change
-      fee: params.feeInfo,
-    };
-  }
-
   /**
    * Create a new transaction builder for the current chain
    * @return a new transaction builder

diff --git a/modules/sdk-coin-polygon/package.json b/modules/sdk-coin-polygon/package.json
@@ -47,10 +47,7 @@
     "@bitgo/statics": "^29.0.0",
     "@bitgo/utxo-lib": "^9.16.0",
     "@ethereumjs/common": "^2.6.5",
-    "@ethereumjs/tx": "^3.3.0",
-    "bignumber.js": "^9.0.0",
     "ethereumjs-abi": "^0.6.5",
-    "lodash": "^4.17.14",
     "superagent": "^3.8.3"
   },
   "devDependencies": {