Skip to content

Commit

Permalink
Merge pull request #4051 from BitGo/PX-000000/mmcshinsky-migrate-dock…
Browse files Browse the repository at this point in the history
…er-builds

feat: migrate docker builds
  • Loading branch information
mmcshinsky-bitgo authored Nov 9, 2023
2 parents d90bef1 + f67e5b2 commit 03c6fe9
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -187,4 +187,4 @@ jobs:
with:
ref: ${{ github.event.pull_request.head.sha }}
- name: Build BitGoJS Express Docker Image
run: docker build .
run: podman build .
4 changes: 2 additions & 2 deletions modules/express/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@
"upload-artifacts": "node scripts/upload-test-reports.js",
"start": "node bin/bitgo-express",
"update-bitgo": "bash ./scripts/update-bitgo.sh",
"build-docker": "docker build -f ../../Dockerfile --platform=linux/amd64 -t bitgo/express:latest -t bitgo/express:$(jq -r .version < package.json) ../..",
"push-docker": "docker push bitgo/express:latest bitgo/express:$(jq -r .version < package.json)",
"build-docker": "podman build -f ../../Dockerfile --platform=linux/amd64 -t bitgo/express:latest -t bitgo/express:$(jq -r .version < package.json) ../..",
"push-docker": "podman push bitgo/express:latest bitgo/express:$(jq -r .version < package.json)",
"check-fmt": "yarn prettier --check '{src,test}/**/*.{ts,js,json}'",
"unprettied": "grep -R -L --include '*.ts' --include '*.js' --include '*.json' '@prettier' src test",
"fmt": "yarn prettier --write '{src,test}/**/*.{ts,js,json}'"
Expand Down
4 changes: 2 additions & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -109,8 +109,8 @@
"dev": "tsc -b ./tsconfig.packages.json -w",
"prepare": "husky install",
"sdk-coin:new": "yo ./scripts/sdk-coin-generator && yarn update-dockerfile",
"build-docker-express": "yarn update-dockerfile && docker build --platform=linux/amd64 -t bitgo/express:latest -t bitgo/express:$(jq -r .version < modules/express/package.json) .",
"push-docker-express": "docker push bitgo/express:latest && docker push bitgo/express:$(jq -r .version < modules/express/package.json)",
"build-docker-express": "yarn update-dockerfile && podman build --platform=linux/amd64 -t bitgo/express:latest -t bitgo/express:$(jq -r .version < modules/express/package.json) .",
"push-docker-express": "podman push bitgo/express:latest && podman push bitgo/express:$(jq -r .version < modules/express/package.json)",
"update-dockerfile": "ts-node scripts/update-dockerfile.ts",
"precommit": "lint-staged",
"lint-fix": "lerna run lint --parallel -- --fix",
Expand Down

0 comments on commit 03c6fe9

Please sign in to comment.