Preemptive Authentication POC #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guian Gumpac <[email protected]>
Signed-off-by: Guian Gumpac <[email protected]>
GumpacG
requested review from
a team,
acarbonetto and
matthewryanwells
and removed request for
acarbonetto and
matthewryanwells
matthewryanwells
approved these changes
Apr 18, 2023
src/main/java/org/opensearch/jdbc/transport/http/ApacheHttpTransport.java
Show resolved
Hide resolved
MaxKsyunz
reviewed
Apr 19, 2023
| return httpClient.execute(request); | ||
| } catch (IOException e) { | ||
| } catch (IOException | AuthenticationException e) { |
There was a problem hiding this comment.
What was happening without catching AuthenticationException?
There was a problem hiding this comment.
Compilation error because of new BasicScheme().authenticate().
Signed-off-by: Guian Gumpac <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Created a new driver connection property to set preemptive authentication to work with SAML authentication. Authentication is set to non-preemptive by default and can be changed by setting
usePreemptiveAuthtotrue.Issues Resolved
opensearch-project#28
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.