(Sentinel) Fix dal stats chcker, struct properties should be public to be parsed through pgx #2226
Conversation
WalkthroughWalkthroughThe changes involve modifications to the SQL query and updates to the data structures in the application. The SQL constant Changes
Sequence Diagram(s)sequenceDiagram
participant DB as Database
participant App as Application
participant Key as Key Struct
participant Count as Count Struct
App->>DB: Request GetAllValidKeys
DB-->>App: Return Key, Description
App->>Key: Initialize Key struct
App->>Count: Initialize Count struct
App->>Key: Access Key.Field
App->>Count: Access Count.Field
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- node/pkg/checker/dalstats/app.go (2 hunks)
Additional comments not posted (6)
node/pkg/checker/dalstats/app.go (6)
18-18: LGTM!The SQL query now selects specific columns, which improves performance and clarity by only fetching necessary fields.
The code changes are approved.
26-26: LGTM!The
DBKeystruct fieldkeyhas been renamed toKeyto follow Go's exported naming conventions, enhancing visibility and accessibility.The code changes are approved.
27-27: LGTM!The
DBKeystruct fielddescriptionhas been renamed toDescriptionto follow Go's exported naming conventions, enhancing visibility and accessibility.The code changes are approved.
31-31: LGTM!The
Countstruct fieldcounthas been renamed toCountto follow Go's exported naming conventions, enhancing visibility and accessibility.The code changes are approved.
81-81: LGTM!The code now references
key.Descriptioninstead of the previous unexported counterpart, reflecting the updated struct field name and ensuring proper access.The code changes are approved.
85-101: LGTM!The code now references
key.Keyinstead of the previous unexported counterpart, and the message formatting at the end of the function has been adjusted to accommodate the new field names. These changes reflect the updated struct field names and ensure proper access.The code changes are approved.
Description
Found out that the struct properties weren't setup as public leading to query failure
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment