-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(OraklNode) Implement proxy for websocket fetchers #2206
Conversation
WalkthroughWalkthroughThe changes involve enhancements to the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- node/pkg/websocketfetcher/app.go (4 hunks)
Additional comments not posted (3)
node/pkg/websocketfetcher/app.go (3)
110-110
: Addition ofproxies
field is appropriate.The addition of the
proxies
field to theApp
struct aligns with the PR objective of implementing proxy support for websocket fetchers.
118-122
: Database query for proxies is correctly implemented.The
Init
method now queries the database for proxies and assigns them to theproxies
field, which is a necessary step for implementing proxy support.
205-211
: Proxy support ininitializeCex
is well-implemented.The use of round-robin selection for proxies and the construction of the proxy URL are correctly implemented. The logic handles cases where no proxies are available.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
This reverts commit 8b9bb7a.
Description
use proxy from websocket fetchers.
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment