Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OraklNode) Implement proxy for websocket fetchers #2206

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

nick-bisonai
Copy link
Collaborator

Description

use proxy from websocket fetchers.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Aug 23, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner August 23, 2024 05:46
Copy link
Contributor

coderabbitai bot commented Aug 23, 2024

Walkthrough

Walkthrough

The changes involve enhancements to the App struct within the websocketfetcher package, specifically by introducing a proxies field to manage proxy configurations. The Init method is updated to retrieve proxy entries from a database, and the initializeCex method is modified to utilize these proxies when creating fetchers. This alters the control flow and configuration process for network requests.

Changes

Files Change Summary
node/pkg/websocketfetcher/app.go Added proxies field to App struct; modified Init method to load proxies from the database with error handling; updated initializeCex method to use proxies for fetcher creation.

Poem

In a world of wires and streams so bright,
A rabbit hops with pure delight.
Proxies now dance in a row,
Fetching data, oh what a show!
With every hop, we leap and bound,
For network requests, new joy is found! 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@nick-bisonai nick-bisonai linked an issue Aug 23, 2024 that may be closed by this pull request
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 01ace43 and 822b2cf.

Files selected for processing (1)
  • node/pkg/websocketfetcher/app.go (4 hunks)
Additional comments not posted (3)
node/pkg/websocketfetcher/app.go (3)

110-110: Addition of proxies field is appropriate.

The addition of the proxies field to the App struct aligns with the PR objective of implementing proxy support for websocket fetchers.


118-122: Database query for proxies is correctly implemented.

The Init method now queries the database for proxies and assigns them to the proxies field, which is a necessary step for implementing proxy support.


205-211: Proxy support in initializeCex is well-implemented.

The use of round-robin selection for proxies and the construction of the proxy URL are correctly implemented. The logic handles cases where no proxies are available.

Copy link
Contributor

@Intizar-T Intizar-T left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@nick-bisonai nick-bisonai merged commit 8b9bb7a into master Aug 23, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the feat/proxy-websocket branch August 23, 2024 09:38
nick-bisonai added a commit that referenced this pull request Aug 23, 2024
nick-bisonai added a commit that referenced this pull request Aug 23, 2024
@coderabbitai coderabbitai bot mentioned this pull request Oct 11, 2024
8 tasks
@coderabbitai coderabbitai bot mentioned this pull request Nov 2, 2024
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(OraklNode) Implement proxy on websocket fetcher initialization
2 participants