(OraklNode) Update timer relative to last update time

[nick-bisonai]

Description

previously, wasn't setting timer properly, not having difference from using ticker, through this update, it'll reset timer relatively based on last update time

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Walkthrough

Walkthrough

The changes involve a modification to the Run method of the WebsocketHelper class in node/pkg/wss/utils.go. The main adjustment is in the handling of the inactivityTimer, where the reset logic now accounts for the actual time elapsed since the last message rather than a fixed timeout value. This change is intended to improve the responsiveness of the inactivity timer and enhance the management of websocket connections.

Changes

Files	Change Summary
node/pkg/wss/utils.go	Modified the Run method in the WebsocketHelper class to adjust the inactivity timer reset logic, accounting for the actual time since the last message.

Poem

🐰 In the realm of webs so wide,
A timer's dance, we now abide.
With clever tweaks, it tracks the flow,
No more haste in letting go.
Each message counts, as time takes flight,
Connections thrive, both day and night! 🌙✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 5bd05cb and a0d0f42.

Files selected for processing (1)

• node/pkg/wss/utils.go (1 hunks)

Additional context used

Learnings (2)

Common learnings

Learnt from: nick-bisonai
PR: Bisonai/orakl#1524
File: node/pkg/wss/utils.go:0-0
Timestamp: 2024-05-28T05:35:40.840Z
Learning: The `Run` method in `WebsocketHelper` now includes a context-based mechanism to exit the loop and a flag (`IsRunning`) to prevent multiple instances from running simultaneously.

node/pkg/wss/utils.go (1)

Learnt from: nick-bisonai
PR: Bisonai/orakl#1524
File: node/pkg/wss/utils.go:0-0
Timestamp: 2024-05-28T05:35:40.840Z
Learning: The `Run` method in `WebsocketHelper` now includes a context-based mechanism to exit the loop and a flag (`IsRunning`) to prevent multiple instances from running simultaneously.

Additional comments not posted (1)

node/pkg/wss/utils.go (1)

105-105: Improvement in inactivity timer logic.

The change to reset the inactivityTimer based on the actual time since the last message enhances the responsiveness of the websocket connection management. This adjustment ensures that the timer reflects the true inactivity duration, potentially improving resource management and preventing unnecessary disconnections.

[Intizar-T]

good point!