-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DAL) Prevent deadlock from multiple lock and unlock from single func #2000
Conversation
WalkthroughWalkthroughThe recent changes enhance concurrency control in the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (3)
- node/pkg/dal/api/controller.go (2 hunks)
- node/pkg/dal/api/hub.go (1 hunks)
- node/pkg/dal/api/types.go (1 hunks)
Additional comments not posted (3)
node/pkg/dal/api/types.go (1)
21-21
: Switching fromsync.RWMutex
tosync.Mutex
The change from
sync.RWMutex
tosync.Mutex
simplifies the locking mechanism but may reduce concurrency in read-heavy scenarios. Ensure this trade-off is acceptable for your use case.Evaluate the performance impact, especially in read-heavy scenarios, to ensure this change does not introduce significant bottlenecks.
node/pkg/dal/api/hub.go (1)
121-122
: Ensuring exclusive access incastSubmissionData
Replacing
RLock
withLock
ensures exclusive access toc.clients
during the execution ofcastSubmissionData
. This change improves data integrity but may impact performance in high-load scenarios.Monitor the performance impact, especially under high load, to ensure this change does not introduce significant delays.
node/pkg/dal/api/controller.go (1)
66-72
: Ensuring exclusive access inHandleWebsocket
Replacing
RLock
withLock
ensures exclusive access toh.clients
during subscription updates. Removing the redundant secondLock
call streamlines the control flow, improving thread safety.Monitor the performance impact, especially under high load, to ensure this change does not introduce significant delays.
Description
h.clients
access is not thread safe, this update covers full mutex lock for single subscribe commandType of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment