rollback node and dal data delay logs

[Intizar-T]

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Walkthrough

Walkthrough

The recent changes streamline the SubmissionData structure and related functionalities by removing the PublishTime field. This adjustment simplifies data handling in various methods, including those processing incoming data and publishing global aggregates. As a result, the codebase becomes more efficient, reducing unnecessary logging and conditional checks related to timing, which may enhance overall performance and clarity in data management.

Changes

File	Change Summary
node/pkg/aggregator/types.go	Removed PublishTime field from SubmissionData struct, altering its representation and related functionalities.
node/pkg/aggregator/utils.go	Eliminated PublishTime initialization and logging in PublishGlobalAggregateAndProof, simplifying the function.
node/pkg/dal/collector/collector.go	Removed time-related checks and logging from processIncomingData, streamlining data processing and logic.

Poem

🐰 In the code where changes dance,
A hop, a skip, a new advance!
No more time to log and fret,
Simplicity is here, you bet!
With cleaner paths we bound and play,
Efficiency is here to stay! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 11d824f and 80c0d3d.

Files selected for processing (3)

• node/pkg/aggregator/types.go (1 hunks)
• node/pkg/aggregator/utils.go (1 hunks)
• node/pkg/dal/collector/collector.go (2 hunks)

Files skipped from review due to trivial changes (2)

• node/pkg/aggregator/utils.go
• node/pkg/dal/collector/collector.go

Additional comments not posted (1)

node/pkg/aggregator/types.go (1)

Line range hint 33-36:
Verify the removal of all references to PublishTime.

The PublishTime field has been removed from the SubmissionData struct. Ensure that all references to PublishTime in the codebase are removed or updated accordingly.

Verification successful

---

Verification successful: All references to PublishTime have been removed.

The PublishTime field has been removed from the SubmissionData struct, and there are no lingering references to it in the codebase.

• No direct references to PublishTime found.
• No variations (e.g., publishTime, PUBLISH_TIME) found.
• No commented-out code referencing PublishTime found.
• No functions or methods referencing PublishTime found.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Verify the removal of all references to `PublishTime` in the codebase.

# Test: Search for references to `PublishTime`. Expect: No occurrences.
rg --type go 'PublishTime'

Length of output: 26

---

Script:

#!/bin/bash
# Description: Verify the removal of all references to `PublishTime` in the codebase, including variations and indirect references.

# Test 1: Search for variations of `PublishTime` (e.g., publishTime, PUBLISH_TIME).
rg --type go 'publishTime'
rg --type go 'PUBLISH_TIME'

# Test 2: Search for commented-out code that might reference `PublishTime`.
rg --type go '//.*PublishTime'

# Test 3: Search for functions or methods that might have used `PublishTime`.
rg --type go 'PublishTime' -A 5

Length of output: 119