-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(DAL) Add endpoint to get all symbols #1764
Conversation
WalkthroughWalkthroughA new function, Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- node/pkg/dal/api/controller.go (1 hunks)
- node/pkg/dal/api/route.go (1 hunks)
Additional comments not posted (2)
node/pkg/dal/api/route.go (1)
11-11
: The route addition is correct.The route
/symbols
is correctly mapped to thegetSymbols
function.node/pkg/dal/api/controller.go (1)
213-219
: The method implementation is correct.The
getSymbols
method correctly retrieves the list of symbols fromApiController.configs
and returns it as JSON.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Description
/dal/symbols
endpoints returns all symbols in list of stringsdocs will be updated accordingly
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment