fix cli test workflow

[Intizar-T]

Description

Please include a summary of the changes and the related issue.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Walkthrough

Walkthrough

This update enhances both the CLI test workflow by extending the test job timeout and adding steps for delegator database setup and service health checks, and the test case in cli/test/delegator.ts by ensuring numerical comparison of organization IDs.

Changes

Files	Change Summary
.github/workflows/cli.test.yaml	Increased test job timeout to 10 minutes, added steps for creating delegator database and health checks.
cli/test/delegator.ts	Converted reporter.organizationId and organization.id to numbers before assertion.

Possibly related issues

• cli test workflow fails #1735: The change to the workflow in .github/workflows/cli.test.yaml likely addresses migration-related issues mentioned in this issue.

Poem

In code we made a grand repair,
With databases handled with care.
Ten minutes now, the tests extend,
Ensuring bugs meet their end.
IDs now in numerical grace,
Each test detail falls in place.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between c693d8a and f0701df.

Files selected for processing (2)

• .github/workflows/cli.test.yaml (3 hunks)
• cli/test/delegator.ts (1 hunks)

Additional comments not posted (4)

cli/test/delegator.ts (1)

46-46: LGTM! Ensures correct type comparison.

The change to convert both reporter.organizationId and organization.id to numbers before comparison is a good practice to avoid type coercion issues.

.github/workflows/cli.test.yaml (3)

14-14: Timeout extension approved, monitor test duration.

Extending the timeout from 3 minutes to 10 minutes is reasonable if tests require more time. However, consider monitoring the test duration to identify any potential inefficiencies.

---

70-74: Database setup steps approved.

The steps to create the delegator database and perform migrations are necessary for the tests. Ensure that the environment variables are correctly set.

---

101-114: Service health check steps approved.

The steps to check the health of the Delegator and API services before running the tests ensure that the services are up and running, which is a good practice.

[nick-bisonai]

lgtm!