(Contract) Add check based on last submission time

[nick-bisonai]

Description

Adds logic to store last submission time and check if submitted timestamp is newer than last submission

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• This change requires a documentation update

Checklist before requesting a review

• I have performed a self-review of my code.
• If it is a core feature, I have added thorough tests.

Deployment

• Should publish npm package
• Should publish Docker image

[coderabbitai]

Warning

Rate Limit Exceeded

@nick-bisonai has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 11 minutes and 19 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 3a83231 and 95b4e0e.

Walkthrough

The SubmissionProxy.sol contract has been enhanced with a new feature to track the last submission time for each feed. This involves adding a new mapping, lastSubmissionTimes, and updating the submission logic to incorporate checks and updates based on this new mapping.

Changes

File Path	Change Summary
contracts/v0.2/src/SubmissionProxy.sol	Added lastSubmissionTimes mapping to track last submission times for each feed. Updated submission logic to check and update this mapping.

🐰
In code so fine, a change was made,
To track the times submissions played.
With mappings new and logic bright,
Each feed now knows its timely right.
The proxies cheer, their task aligned,
As rabbits hop through code refined. 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 6fb7915 and 3a83231.

Files selected for processing (1)

• contracts/v0.2/src/SubmissionProxy.sol (3 hunks)

Additional Context Used

Learnings (1)

contracts/v0.2/src/SubmissionProxy.sol (1)

User: martinkersner
PR: Bisonai/orakl#1244
File: contracts/v0.2/src/SubmissionProxy.sol:65-73
Timestamp: 2024-03-15T09:15:23.379Z
Learning: Validation for non-zero addresses in the `SubmissionProxy.sol` contract is implemented within the `updateFeed` function, as confirmed by the user. This ensures data integrity by centralizing the validation logic.

Additional comments not posted (2)

contracts/v0.2/src/SubmissionProxy.sol (2)

41-41: Addition of lastSubmissionTimes mapping is well-implemented.

This mapping is crucial for tracking the last submission times as per the new feature requirements.

---

Line range hint 362-387: Ensure proper handling of timestamp checks and updates in the submit function.

The logic to check if the submission is newer than the last submission and the update of lastSubmissionTimes after a successful submission are correctly implemented. This aligns with the PR's objectives to process only newer submissions.

[Intizar-T]

lgtm!

[martinkersner]

LGTM!