Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(OraklNode) Remove underscore var #1195

Merged
merged 2 commits into from
Mar 4, 2024
Merged

(OraklNode) Remove underscore var #1195

merged 2 commits into from
Mar 4, 2024

Conversation

nick-bisonai
Copy link
Collaborator

Description

Removes variable names starting with underscore which were supposed to solve shadowing issue, yet leading to less readability
Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Mar 4, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner March 4, 2024 06:27
KelvinThai
KelvinThai approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@KelvinThai KelvinThai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nick-bisonai nick-bisonai merged commit d0d4020 into master Mar 4, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the fix/remove-underscore-var branch March 4, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KelvinThai KelvinThai KelvinThai approved these changes

@martinkersner martinkersner Awaiting requested review from martinkersner

@jay-kim-kor jay-kim-kor Awaiting requested review from jay-kim-kor

Assignees

@nick-bisonai nick-bisonai

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nick-bisonai @KelvinThai