Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(OraklNode) Add github action for testing #1154

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Conversation

nick-bisonai
Copy link
Collaborator

Description

  • linter and vet checks
  • minor updates to fix shadowing error and lint error found while writing github action

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai self-assigned this Feb 21, 2024
@nick-bisonai nick-bisonai requested a review from a team as a code owner February 21, 2024 08:35
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

node/taskfiles/taskfile.local.yml Show resolved Hide resolved
node.Job()
err := node.Job()
if err != nil {
log.Println("failed to execute job:", err)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point, you should start using log levels.

fix: linter fix

fix: fix vet command and shadowing
@nick-bisonai nick-bisonai merged commit 62f74f0 into master Feb 21, 2024
1 check passed
@nick-bisonai nick-bisonai deleted the feat/orakl-node-test branch February 21, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants