(OraklNode) sync roundId based on max suggested id #1099
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RoundId generation
AS - IS
Each peer was generating roundId based on timestamp from each machine. Since each machine could have difference with its generated timestamp, they could've been submitting to different roundId at same tick
TO - BE
This update adds publishing & subscribing layer to synchronize roundId
Other updates
Is it okay?
What if there's a disconnected peer?
I assume that condition checking as followed will also be affected as # of subscribers will decrease.
len(n.Data.SuggestedRounds) > n.getSubscribersCount()
What if there's a disconnected peer but still running?
Currently, node is running(publishing) conditionally only if there's 1 or more connected peers.
What about other fallbacks?
Please list down all edge cases that should be handled
It'll be updated in further PRs
Please help 🥹
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment