Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use node package to fix import error due to node version update #1003

Merged
merged 1 commit into from
Dec 11, 2023

Conversation

nick-bisonai
Copy link
Collaborator

@nick-bisonai nick-bisonai commented Dec 9, 2023

Description

Assuming the import error due to node dropping support for --experimental-specifier-resolution=node option from v19 (https://stackoverflow.com/questions/74660824/nodejs-v19-drops-support-for-es-module-specifier-resolution-node-which-makes-i),

This PR usess specifier-resolution-node package to replace the deprecated node option parameter

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package
  • Should publish Docker image

@nick-bisonai nick-bisonai marked this pull request as ready for review December 11, 2023 02:56
@nick-bisonai nick-bisonai requested a review from a team as a code owner December 11, 2023 02:56
Copy link
Member

@martinkersner martinkersner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nick-bisonai nick-bisonai merged commit 127c944 into master Dec 11, 2023
3 checks passed
@nick-bisonai nick-bisonai deleted the fix/node20-fix branch December 11, 2023 03:50
@martinkersner martinkersner mentioned this pull request Dec 11, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants