fix: fix error

Bisonai · Aug 1, 2024 · af0b75a · af0b75a
1 parent c0552de
commit af0b75a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/node/pkg/dal/api/client.go b/node/pkg/dal/api/client.go
@@ -29,9 +29,9 @@ func (c *ThreadSafeClient) WriteJSON(data any) error {
 	return nil
 }
 
+// even though readjson is not thread safe, it is expected not be called concurrently
+// since the only place it is called is from `HandleWebsocket` inner for loop
 func (c *ThreadSafeClient) ReadJSON(data any) error {
-	c.mu.Lock()
-	defer c.mu.Unlock()
 	if err := c.Conn.ReadJSON(&data); err != nil {
 		log.Error().Err(err).Msg("failed to read json msg")
 		return err

diff --git a/node/pkg/dal/api/controller.go b/node/pkg/dal/api/controller.go
@@ -59,7 +59,7 @@ func HandleWebsocket(conn *websocket.Conn) {
 		var msg Subscription
 		if err = threadSafeClient.ReadJSON(&msg); err != nil {
 			log.Error().Err(err).Msg("failed to read message")
-			continue
+			return
 		}
 
 		if msg.Method == "SUBSCRIBE" {