fix: update based on feedback

Bisonai · May 23, 2024 · 6d9cdc6 · 6d9cdc6
1 parent ed9c9c3
commit 6d9cdc6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/node/pkg/db/redis.go b/node/pkg/db/redis.go
@@ -155,6 +155,7 @@ func LRange(ctx context.Context, key string, start int64, end int64) ([]string,
 	rdbConn, err := GetRedisConn(ctx)
 	if err != nil {
 		log.Error().Err(err).Msg("Error getting redis connection")
+		return nil, err
 	}
 	return rdbConn.LRange(ctx, key, start, end).Result()
 }
@@ -163,6 +164,7 @@ func LPush(ctx context.Context, key string, values ...any) error {
 	rdbConn, err := GetRedisConn(ctx)
 	if err != nil {
 		log.Error().Err(err).Msg("Error getting redis connection")
+		return err
 	}
 	return rdbConn.LPush(ctx, key, values...).Err()
 }

diff --git a/node/pkg/db/redis_test.go b/node/pkg/db/redis_test.go
@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"reflect"
 	"sort"
+	"strings"
 	"testing"
 	"time"
 
@@ -425,7 +426,7 @@ func TestPopAll(t *testing.T) {
 
 	// Check if the list is empty after popping
 	result, err := Get(ctx, key)
-	if err == nil {
+	if err == nil || !strings.Contains(err.Error(), "Error getting list: redis: nil") {
 		t.Fatalf("Expected to have err")
 	}
 	if len(result) != 0 {
@@ -472,7 +473,7 @@ func TestPopAllObject(t *testing.T) {
 
 	// Check if the list is empty after popping
 	result, err := Get(ctx, key)
-	if err == nil {
+	if err == nil || !strings.Contains(err.Error(), "Error getting list: redis: nil") {
 		t.Fatalf("Expected to have err")
 	}
 	if len(result) != 0 {