deploy cypress-cli-v0.6.1.20240507.0716.2268213 #353
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress-cli-v0.6.1.20240507.0716.2268213
Manually add .js extension to relative imports
Closes #1454
Description
We are using ES modules in the
cli
workspace and currently, most if not all of our imports in the cli workspace don't include the file extension, which is a requirement in ES modules. Since tsc doesn't add .js extension during compilation, there is amodule not found
error when we try to runnode dist/index.js
.This PR:
.js
extensions to all importseslint-plugin-import
package to provide linting error suggestions when imported file extension is not provided (ignores the test dir)I've tested running the cli executable after these implementations and the
module not found
error has been resolved.Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Deployment
Should publish npm package
Should publish Docker image
PR: 1455