Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy baobab-cli-v0.6.1.20240507.0716.2268213 #352

Conversation

nick-bisonai
Copy link
Contributor

baobab-cli-v0.6.1.20240507.0716.2268213

Manually add .js extension to relative imports

Closes #1454

Description

We are using ES modules in the cli workspace and currently, most if not all of our imports in the cli workspace don't include the file extension, which is a requirement in ES modules. Since tsc doesn't add .js extension during compilation, there is a module not found error when we try to run node dist/index.js.

This PR:

  • manually adds .js extensions to all imports
  • adds an eslint-plugin-import package to provide linting error suggestions when imported file extension is not provided (ignores the test dir)

I've tested running the cli executable after these implementations and the module not found error has been resolved.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Deployment

  • Should publish npm package

  • Should publish Docker image

  • PR: 1455

@nick-bisonai nick-bisonai deleted the deploy/baobab-cli-v0.6.1.20240507.0716.2268213 branch May 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant