deploy cypress-cli-v0.6.1.20240403.0741.b1cbae4 #266
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cypress-cli-v0.6.1.20240403.0741.b1cbae4
Signature verification
Description
This PR implements submission with proof. Submission with proof can be either passed through
SubmissionProxy
or throughFeed
directly. It is possible to submit values with or without proof which can be recognized byverified
property ofRound
struct. The verification is performed withinFeed
contract. By default, proof is required (proofRequired
) for all submission. If one wants to allow submissions without proof, owner has to callsetProofRequired(false)
.Proof generation
Every node produces proof independently, and shares it with the rest of the node set.
Reporter collects all proofs and concatenates them into a single continuous bytes memory, which is then submitted with
feeds
andsubmissions
arguments.Proof verification
Submitted proofs are verified within
Feed
contract, where from each proof we extract signer and test whether it is whitelisted. If not, verification fails and currently whole transaction is rejected. This issue will be attended in Bisonai/orakl#1334.Related follow-up tasks
Feed
toSubmissionProxy
orakl#1336Type of change
Please delete options that are not relevant.
Checklist before requesting a review
Summary by CodeRabbit