Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deploy cypress-cli-v0.6.1.20240403.0741.b1cbae4 #266

Conversation

nick-bisonai
Copy link
Contributor

cypress-cli-v0.6.1.20240403.0741.b1cbae4

Signature verification

Description

This PR implements submission with proof. Submission with proof can be either passed through SubmissionProxy or through Feed directly. It is possible to submit values with or without proof which can be recognized by verified property of Round struct. The verification is performed within Feed contract. By default, proof is required (proofRequired) for all submission. If one wants to allow submissions without proof, owner has to call setProofRequired(false).

Proof generation

Every node produces proof independently, and shares it with the rest of the node set.

msg = keccak256(abi.encodePacked(submission))
proof = sign(sk, msg)

Reporter collects all proofs and concatenates them into a single continuous bytes memory, which is then submitted with feeds and submissions arguments.

Proof verification

Submitted proofs are verified within Feed contract, where from each proof we extract signer and test whether it is whitelisted. If not, verification fails and currently whole transaction is rejected. This issue will be attended in Bisonai/orakl#1334.

Related follow-up tasks

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.

Summary by CodeRabbit

  • New Features
    • Introduced a verification system for data submissions, allowing for enhanced data integrity and trustworthiness.
    • Added functionality to require proof of verification for data submissions, improving security measures.
  • Enhancements
    • Updated data retrieval functions across several contracts to include verification status, making it easier for users to identify trusted data.
  • Tests
    • Adjusted tests to accommodate new verification features and ensure robustness of the verification system.
  • PR: 1331

@nick-bisonai nick-bisonai deleted the deploy/cypress-cli-v0.6.1.20240403.0741.b1cbae4 branch April 3, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant