Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discourage the use of Object#delay and Delayed::Job.enqueue #54

Merged
merged 4 commits into from
Sep 26, 2024
Merged

Discourage the use of Object#delay and Delayed::Job.enqueue #54

merged 4 commits into from
Sep 26, 2024

Conversation

rzane
Copy link
Contributor

@rzane rzane commented Sep 20, 2024

We want all of our jobs to use ActiveJob.

smudge
smudge approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM - this is a good push, and we've been using ActiveJob APIs for long enough that I don't think this is too heavy-handed.

smudge
smudge approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM

@smudge smudge merged commit 4a773b0 into Betterment:main Sep 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smudge smudge smudge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rzane @smudge