Evaluate as command #2684
Draft
Evaluate as command #2684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
CI fails when I add the new file webview.ts, so to work around that I'll just add the webview to snippets
|
So sweet! Thanks for working on this! 🙏 |
PEZ
reviewed
Jan 6, 2025
There was a problem hiding this comment.
There is a commands reference built in to VS Code. Perhaps it is better to refer to that, than to maintain our own? I see that there's automation to this one, but still. This one is indexed by search engines, so it may be worth it from that standpoint. WDYT?
PEZ
reviewed
Jan 6, 2025
Comment on lines
+2178
to
+2191
| "category": "Calva", | ||
| "command": "calva.info", | ||
| "title": "Show Information Message" | ||
| }, | ||
| { | ||
| "category": "Calva", | ||
| "command": "calva.warn", | ||
| "title": "Show Warning Message" | ||
| }, | ||
| { | ||
| "category": "Calva", | ||
| "command": "calva.error", | ||
| "title": "Show Error Message" | ||
| }, |
There was a problem hiding this comment.
Maybe people can use Joyride to reach functionality like this instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Fixes #2683
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik