Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlighter stashes discovery of mismatched brackets in mirrorDoc[hig… #2674

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Highlighter stashes discovery of mismatched brackets in mirrorDoc[hig… #2674

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/highlight/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ function updateRainbowBrackets() {
}
}
activeEditor.setDecorations(misplacedType, misplaced);
mirrorDoc["highlightFoundMisplacedBrackets"] = misplaced.length; // help tests 'see' that misplaced brackets are highlighted
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this property will be used elsewhere (in tests?), I think it's a good idea to assign it to a var somewhere and only use the string in that assignment, and use the var here and elsewhere.

activeEditor.setDecorations(commentFormType, comment_forms);
activeEditor.setDecorations(ignoredFormType, ignores);
activeEditor.setDecorations(ignoredTopLevelFormType, topLevelIgnores);
Expand Down