Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various optimizations #319

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

fix reproducibility issue

d633f10
Select commit
Loading
Failed to load commit list.
Open

Various optimizations #319

fix reproducibility issue
d633f10
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 11, 2025 in 1s

91.52% (target 80.00%)

View this Pull Request on Codecov

91.52% (target 80.00%)

Details

Codecov Report

Attention: Patch coverage is 99.57082% with 1 line in your changes missing coverage. Please review.

Project coverage is 91.52%. Comparing base (fe28e13) to head (d633f10).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/scenic/core/regions.py 99.25% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #319      +/-   ##
==========================================
+ Coverage   91.42%   91.52%   +0.10%     
==========================================
  Files          54       54              
  Lines       13575    13753     +178     
==========================================
+ Hits        12411    12588     +177     
- Misses       1164     1165       +1     
Files with missing lines Coverage Δ
src/scenic/core/object_types.py 93.16% <100.00%> (+0.30%) ⬆️
src/scenic/core/requirements.py 96.07% <100.00%> (+0.16%) ⬆️
src/scenic/core/sample_checking.py 83.13% <100.00%> (+0.85%) ⬆️
src/scenic/core/scenarios.py 94.39% <100.00%> (+0.01%) ⬆️
src/scenic/core/shapes.py 97.87% <100.00%> (+2.63%) ⬆️
src/scenic/core/utils.py 82.03% <100.00%> (+0.07%) ⬆️
src/scenic/core/regions.py 88.22% <99.25%> (+0.82%) ⬆️

... and 5 files with indirect coverage changes